Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Remove remaining usage of winuwp flag #33290

Merged
fluttergithubbot merged 1 commit into from
May 12, 2022
Merged

[Windows] Remove remaining usage of winuwp flag #33290

fluttergithubbot merged 1 commit into from
May 12, 2022

Conversation

@moko256
Copy link
Contributor

@moko256 moko256 commented May 12, 2022

Fixes: flutter/flutter#103586.

No changes in flutter/tests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jnschulze jnschulze self-requested a review May 12, 2022 16:13
@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 12, 2022
@fluttergithubbot fluttergithubbot merged commit 6543874 into flutter:main May 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2022
@engine-flutter-autoroll
6543874 [Windows] Remove remaining usage of winuwp flag (flutter/engi…
7766e6d 
…ne#33290)
cbracken
cbracken reviewed May 26, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@moko256 @houhuayong
[Windows] Remove remaining usage of winuwp flag (flutter#33290)
fff26a2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@cbracken cbracken cbracken left review comments

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@jnschulze jnschulze jnschulze approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-windows waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove remaining usage of winuwp flag

5 participants

@moko256 @chinmaygarde @cbracken @jnschulze @fluttergithubbot