Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Update ICU to 71-1 (#32879)" #33274

Merged
harryterkelsen merged 4 commits into from
May 13, 2022
Merged

Revert "Update ICU to 71-1 (#32879)" #33274

harryterkelsen merged 4 commits into from
May 13, 2022

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented May 11, 2022

This reverts commit 61124ef.

This roll was causing code size issued in Fuchsia.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented May 11, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

ditman
ditman approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it's odd that the licenses are not reverting "cleanly" to the same hash or something (I guess there were other modifications to the file in between?)

@harryterkelsen harryterkelsen merged commit 24e7c0c into flutter:main May 13, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 13, 2022
@engine-flutter-autoroll
24e7c0c Revert "Update ICU to 71-1 (flutter#32879)" (flutter/engine#3…
461d305 
…3274)
harryterkelsen added a commit to harryterkelsen/engine that referenced this pull request May 18, 2022
@harryterkelsen
Revert "Revert "Update ICU to 71-1 (flutter#32879)" (flutter#33274)"
8623343 
This reverts commit 24e7c0c.
@filmil filmil mentioned this pull request Jun 6, 2022
Merged
8 tasks
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@houhuayong
Revert "Update ICU to 71-1 (flutter#32879)" (flutter#33274)
caece5a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

1 more reviewer

@ditman ditman ditman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harryterkelsen @ditman