compile a flutter tester with SUPPORT_FRACTIONAL_TRANSLATION and raster cache disabled #33272
Conversation
…ne into a_tale_of_two_testers
shell/testing/BUILD.gn
Outdated
| } | ||
|
|
||
| # A second tester binary with SUPPORT_FRACTIONAL_TRANSLATION enabled. | ||
| executable("testing_v2") { |
There was a problem hiding this comment.
please name this something clearer. Something like
testing_fractional_translation.
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM.
Consider picking a more descriptive name.
jonahwilliams
added
the
waiting for tree to go green
shell/testing/BUILD.gn
Outdated
|
|
||
| # A second tester binary with SUPPORT_FRACTIONAL_TRANSLATION enabled. | ||
| executable("testing_fractional_translation") { | ||
| output_name = "flutter_tester_v2" |
There was a problem hiding this comment.
Another nit: update the output_name too.
There was a problem hiding this comment.
lutter_tester_testing_factional_translation?
jonahwilliams
removed
the
waiting for tree to go green
jonahwilliams
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I'm going to count running the existing tests with the new tester variant as tested |
jonahwilliams
added
waiting for tree to go green
…and raster cache disabled (flutter/engine#33272)
…er cache disabled (flutter#33272)
3 participants
By turning off pixel snapping in the tester, we believe that we can stabilize a significant number of google3 goldens that get invalidated when we change how layers composite.