Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Migrate Flutter Web DOM usage to JS static interop - 15. #33247

Merged
joshualitt merged 2 commits into from
May 18, 2022
Merged

[web] Migrate Flutter Web DOM usage to JS static interop - 15. #33247

joshualitt merged 2 commits into from
May 18, 2022

Conversation

@joshualitt
Copy link
Contributor

@joshualitt joshualitt commented May 11, 2022

This is CL 15 in a series of CLs to migrate Flutter Web DOM usage to the new JS static interop API.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label May 11, 2022
@skia-gold
Copy link

skia-gold commented May 11, 2022

Gold has detected about 1 new digest(s) on patchset 6.
View them at https://flutter-engine-gold.skia.org/cl/github/33247

@flutter-dashboard
Copy link

flutter-dashboard bot commented May 11, 2022

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #33247 at sha a011244

@joshualitt joshualitt requested a review from yjbanov May 11, 2022 16:57
@joshualitt
Copy link
Contributor Author

joshualitt commented May 11, 2022

@yjbanov ptal. Please only look at CL 15:
fd14b20

Or using compare: joshualitt/engine@html_14...joshualitt:html_15

yjbanov
yjbanov approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshualitt joshualitt force-pushed the html_15 branch 3 times, most recently from 4456479 to 0802e8e Compare May 14, 2022 01:35
@joshualitt joshualitt merged commit 6d1617a into flutter:main May 18, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 18, 2022
@engine-flutter-autoroll
6d1617a [web] Migrate Flutter Web DOM usage to JS static interop - 15. (
99a4bef 
flutter/engine#33247)
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@joshualitt @houhuayong
[web] Migrate Flutter Web DOM usage to JS static interop - 15. (flutt…
d633083 
…er#33247)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-web Code specifically for the web engine will affect goldens

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshualitt @skia-gold @yjbanov