Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@muditatandon
Copy link

@muditatandon muditatandon commented May 9, 2022

…(#33169)

Co-authored-by: Jim Graham [email protected]

It was partially removed in
https://fuchsia-review.googlesource.com/c/fuchsia/+/674049; this commit
allows remaining references to be removed.

Co-authored-by: Tamir Duberstein [email protected]

Co-authored-by: Jim Graham [email protected]
Co-authored-by: Tamir Duberstein [email protected]

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…lutter#33169)

* [flutter_releases] Fix condition in OpacityLayer where it inherits opacity twice (flutter#33085) (flutter#33105)

Co-authored-by: Jim Graham <[email protected]>

* [flutter_releases] Remove reference to FX_LOG_ALL (flutter#33027) (flutter#33147)

It was partially removed in
https://fuchsia-review.googlesource.com/c/fuchsia/+/674049; this commit
allows remaining references to be removed.

Co-authored-by: Tamir Duberstein <[email protected]>

Co-authored-by: Jim Graham <[email protected]>
Co-authored-by: Tamir Duberstein <[email protected]>
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@muditatandon muditatandon requested a review from CaseyHillers May 9, 2022 21:36
@muditatandon muditatandon merged commit 3c78298 into flutter:flutter-2.13-candidate.10 May 9, 2022
muditatandon added a commit to muditatandon/engine that referenced this pull request May 13, 2022
…lutter#33169) (flutter#33222)

* [flutter_releases] Fix condition in OpacityLayer where it inherits opacity twice (flutter#33085) (flutter#33105)

Co-authored-by: Jim Graham <[email protected]>

* [flutter_releases] Remove reference to FX_LOG_ALL (flutter#33027) (flutter#33147)

It was partially removed in
https://fuchsia-review.googlesource.com/c/fuchsia/+/674049; this commit
allows remaining references to be removed.

Co-authored-by: Tamir Duberstein <[email protected]>

Co-authored-by: Jim Graham <[email protected]>
Co-authored-by: Tamir Duberstein <[email protected]>

Co-authored-by: Casey Hillers <[email protected]>
Co-authored-by: Jim Graham <[email protected]>
Co-authored-by: Tamir Duberstein <[email protected]>
muditatandon added a commit to muditatandon/engine that referenced this pull request May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants