Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add linux android debug engine builder. #33218

Merged
fluttergithubbot merged 1 commit into from
May 9, 2022
Merged

Add linux android debug engine builder. #33218

fluttergithubbot merged 1 commit into from
May 9, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented May 9, 2022

This is part of the migration of builders to the engine v2 recipes.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Add linux android debug engine builder.
afc92b5 
This is part of the migration of builders to the engine v2 recipes.

Bug: flutter/flutter#81855
@godofredoc godofredoc requested review from keyonghan and yusuf-goog May 9, 2022 20:45
@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 9, 2022
@fluttergithubbot fluttergithubbot merged commit 558cbbb into flutter:main May 9, 2022
@godofredoc godofredoc deleted the enable-linux-debug-android branch May 9, 2022 23:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2022
@engine-flutter-autoroll
558cbbb Add linux android debug engine builder. (flutter/engine#33218)
c90ae21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@keyonghan keyonghan Awaiting requested review from keyonghan

1 more reviewer

@yusuf-goog yusuf-goog yusuf-goog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @yusuf-goog @fluttergithubbot