Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

android accessibility bridge performSetText also removes string attributes #33217

Merged
chunhtai merged 1 commit into from
May 12, 2022
Merged

android accessibility bridge performSetText also removes string attributes #33217

chunhtai merged 1 commit into from
May 12, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented May 9, 2022 •
edited
Loading

…butes

fixes flutter/flutter#103354

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai requested a review from blasten May 9, 2022 20:14
blasten
blasten approved these changes May 10, 2022
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 10, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 10, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac iOS Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 10, 2022
@chunhtai chunhtai merged commit 5f3119a into flutter:main May 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 12, 2022
@engine-flutter-autoroll
5f3119a android accessibility bridge performSetText also removes stri…
5f06518 
…ng attributes (flutter/engine#33217)
@HansMuller HansMuller changed the title android accessibility bridge performSetText also removes string attri… android accessibility bridge performSetText also removes string attributes Jun 6, 2022
houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022
@chunhtai @houhuayong
android accessibility bridge performSetText also removes string attri…
f6983fc 
…butes (flutter#33217)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Android][A11y] voice access clear text causes crash if its value is attributed string

3 participants

@chunhtai @fluttergithubbot @blasten