This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Do not pass nullable parameters of simple types to Tonic-wrapped native functions #33159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
May 6, 2022
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
Lgtm
We should also update the DartWrappable converter to check for null
…ve functions Tonic converters for simple types do not expect to receive nulls from Dart. If the caller uses a null, then Tonic will pass the null to Dart APIs such as Dart_GetNativeDoubleArgument which will return an error handle. Tonic then ignores the error and returns a default value for the converted type. This PR does an explicit mapping from nulls to default values and avoids the unnecessary overhead of constructing the error in the Dart APIs. Also add a test that checks function signatures in the dart:ui package for nullable arguments of these types.
jason-simmons
force-pushed
the
native_no_null_primitives
branch
from
cb9d717 to
fcc7e89
Compare
jason-simmons
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 9, 2022
…ped native functions (flutter/engine#33159)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tonic converters for simple types do not expect to receive nulls from Dart.
If the caller uses a null, then Tonic will pass the null to Dart APIs such as
Dart_GetNativeDoubleArgument which will return an error handle. Tonic then
ignores the error and returns a default value for the converted type.
This PR does an explicit mapping from nulls to default values and avoids the
unnecessary overhead of constructing the error in the Dart APIs.
Also add a test that checks function signatures in the dart:ui package for
nullable arguments of these types.