[impeller] OpenGL ES 2.0: Implement texturing and debug object labeling. #33156
Conversation
|
The test failure looks related: |
|
The format issue is now fixed. |
bdero
left a comment
bdero
left a comment
There was a problem hiding this comment.
LGTM! It's awesome that we're able to get some resource labeling in with the debug extension.
|
|
||
| TexImage2DData(PixelFormat pixel_format, | ||
| const uint8_t* contents, | ||
| size_t length) { |
There was a problem hiding this comment.
So I wonder if g3 is OK with std::span yet... I recall trying to sneak it in last year but ran into problems.
There was a problem hiding this comment.
Probably not since its C++20.
There was a problem hiding this comment.
Checked and the answer is indeed no. Still just absl::Span everywhere. FML has a dependency on abseil, but not sure if we want to make a habit of using compat shims like that.
There was a problem hiding this comment.
I also suppose the only cpp20 features that really get turned on are syntax changes (like designated initializers) and not stdlib, since abseil takes care of the stdlib coverage...
|
Mac iOS Engine is failing due to a need for a rebase. |
Labeling will only be enabled when the GL_KHR_debug extension is present (it usually is).
chinmaygarde
added
the
waiting for tree to go green
4 participants
Labeling will only be enabled when the GL_KHR_debug extension is present
(it usually is).
RenderDoc doesn't seem to show labels for buffers where an offset into a buffer is specified. The buffer itself has been labelled in the resources view though.