Add an option to use a prebuilt impellerc #33139
Conversation
fml/BUILD.gn
Outdated
| if (is_mac || is_linux) { | ||
| # This abseil dependency is only used by backtrace.cc. | ||
| deps += [ "//third_party/abseil-cpp/absl/debugging:symbolize" ] | ||
| } |
There was a problem hiding this comment.
Can we still include this for unopt builds? It's helpful to be able to use fml::Backtrace sometimes for local builds. Not a big deal either though since we can just attach a debugger too...
There was a problem hiding this comment.
Added back in unopt builds.
| tool = "//flutter/impeller/compiler:impellerc" | ||
| } | ||
| } else { | ||
| action_foreach(target_name) { |
There was a problem hiding this comment.
Ok to ignore this for this patch.
impellerc may not be stable from revision to revision. We'll want a nice failure mode if/when someone ends up using an incompatible impellerc with the current engine build.
There was a problem hiding this comment.
Added more text to the help message on the gn script flag.
zanderso
force-pushed
the
prebuilt-impellerc
branch
from
b159bf6 to
d76d15f
Compare
|
The tree is really green, the mac try queue isn't going to clear out any time soon, the prod bots are sitting idle, and this is relatively low risk since it doesn't do anything unless the flag is passed, so I'm going to land this without |
2 participants
Building the arm64 iOS simulator and iOS release configurations in CI are very expensive because they can't use goma. This PR removes a dependency on absiel from iOS generally, and adds an option to use a prebuilt impellerc, which we'll use on CI by building impellerc with host_debug first, which can use goma. This should save somewhere between 6-8 minutes on the long-pole build on CI.