This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix gtk targets for arm64 artifacts. #33130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The artifact name and location were using the host_cpu instead of the target_cpu. Bug: flutter/flutter#81855
zanderso
suggested changes
May 5, 2022
shell/platform/linux/BUILD.gn
Outdated
| prefix = "$platform_name-$target_cpu-$flutter_runtime_mode/" | ||
| } | ||
| output = "$prefix$full_platform_name-flutter-gtk.zip" | ||
| output = "${prefix}${platform_name}-${target_cpu}-flutter-gtk.zip" |
Member
There was a problem hiding this comment.
The platform name here should be the target os and not the host os because it does not make sense to mix the host os with the target cpu.
zanderso
reviewed
May 5, 2022
shell/platform/linux/BUILD.gn
Outdated
| prefix = "$target_platform_name-$target_cpu-$flutter_runtime_mode/" | ||
| } | ||
| output = "$prefix$full_platform_name-flutter-gtk.zip" | ||
| output = "${prefix}${target_platform_name}-${target_cpu}-flutter-gtk.zip" |
Member
There was a problem hiding this comment.
Now this is just full_target_platform_name =)
Contributor
Author
There was a problem hiding this comment.
Replaced and re-running all the tests.
zanderso
approved these changes
May 5, 2022
godofredoc
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The artifact name and location were using the host_cpu instead of the
target_cpu.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.