Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add linux_android_aot_engine using recipes v2. #33125

Merged
fluttergithubbot merged 1 commit into from
May 5, 2022
Merged

Add linux_android_aot_engine using recipes v2. #33125

fluttergithubbot merged 1 commit into from
May 5, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented May 5, 2022

This is part of the migration of the engine builds to recipes v2.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Add linux_android_aot_engine using recipes v2.
997b976 
This is part of the migration of the engine builds to recipes v2.

Bug: flutter/flutter#81855
@godofredoc godofredoc requested review from keyonghan and yusuf-goog May 5, 2022 02:48
keyonghan
keyonghan approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 5, 2022
@fluttergithubbot fluttergithubbot merged commit f53c06d into flutter:main May 5, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 6, 2022
@engine-flutter-autoroll
f53c06d Add linux_android_aot_engine using recipes v2. (flutter/engin…
903722a 
…e#33125)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 6, 2022
@engine-flutter-autoroll
f53c06d Add linux_android_aot_engine using recipes v2. (flutter/engin…
aa0e15a 
…e#33125)
@godofredoc godofredoc deleted the add_artifacts_android branch January 12, 2024 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yusuf-goog yusuf-goog Awaiting requested review from yusuf-goog

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @keyonghan @fluttergithubbot