Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Move processing of flutter jars to gn. #33124

Merged
fluttergithubbot merged 1 commit into from
May 5, 2022
Merged

Move processing of flutter jars to gn. #33124

fluttergithubbot merged 1 commit into from
May 5, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented May 5, 2022

This is to remove the artifacts processing logic from recipes.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Move processing of flutter jars to gn.
976d2e3 
This is to remove the artifacts processing logic from recipes.

Bug: flutter/flutter#81855
@godofredoc godofredoc requested review from blasten, dnfield and zanderso May 5, 2022 02:02
@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 5, 2022
@fluttergithubbot fluttergithubbot merged commit 327be3c into main May 5, 2022
zanderso
zanderso reviewed May 5, 2022
View reviewed changes
shell/platform/android/BUILD.gn
artifact_id =
string_replace(android_app_abi, "-", "_") + "_" + flutter_runtime_mode
sources = [
"$root_out_dir/${artifact_id}.jar",
Copy link
Member

@zanderso zanderso May 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://gn.googlesource.com/gn/+/master/docs/reference.md#func_get_target_outputs.

And to filter down to the outputs that you need, you can use https://gn.googlesource.com/gn/+/master/docs/reference.md#func_filter_include

@zanderso zanderso deleted the move_flutter_jars branch May 5, 2022 04:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 5, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 5, 2022
@engine-flutter-autoroll
327be3c Move processing of flutter jars to gn. (flutter/engine#33124)
e52ee97
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dnfield dnfield Awaiting requested review from dnfield

2 more reviewers

@zanderso zanderso zanderso left review comments

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@godofredoc @blasten @zanderso @fluttergithubbot