This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move embedder jar file processing to GN. #33119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recipes currently contain a lot of logic to manipulate jar file names and creating the expected folder structures. This PR moves the logic to process embedder android artifacts to GN. Bug: flutter/flutter#81855
blasten
reviewed
May 4, 2022
build/android_artifacts.py
Outdated
Comment on lines
8
to
9
|
|
||
|
|
blasten
reviewed
May 4, 2022
| import shutil | ||
| import os | ||
| import argparse | ||
|
|
blasten
reviewed
May 4, 2022
build/android_artifacts.py
Outdated
Comment on lines
11
to
14
| import sys | ||
| import shutil | ||
| import os | ||
| import argparse |
blasten
approved these changes
May 4, 2022
godofredoc
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recipes currently contain a lot of logic to manipulate jar file names
and creating the expected folder structures. This PR moves the logic to
process embedder android artifacts to GN.
Bug: flutter/flutter#81855
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.