This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Fix test fixture identifier style #33118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
changed the title
Rename the C++ style can_composite_platform_views and native_callback functions to the Dart-style identifiers canCompositePlatformViews and nativeCallback in the macOS desktop test fixtures. Also corrects the helper method identifier from CreateSimplePicture to _createSimplePicture, thus making it library-private to help readers understand it's a local helper. Ref: [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#naming) Ref: [Effective Dart](https://dart.dev/guides/language/effective-dart/style#do-name-other-identifiers-using-lowercamelcase)
Member
Author
|
Spotted a couple more and pushed an update. |
cbracken
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the C++ style can_composite_platform_views and native_callback
functions to the Dart-style identifiers canCompositePlatformViews and
nativeCallback in the macOS desktop test fixtures.
Also corrects the helper method identifier from CreateSimplePicture to
_createSimplePicture, thus making it library-private to help readers
understand it's a local helper.
Ref: Flutter Style Guide
Ref: Effective Dart
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.