Revert "dart:ui conversion from native to FfiNative" #33116
Conversation
This reverts commit a74a58f.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
added
the
waiting for tree to go green
|
Did this reland? |
|
It was blocked for a while on dart-lang/dartdoc#3033, which has landed and looks like published. We need to rev dartdoc in the framework to reland this. |
|
Actually it looks like the framework just uses whatever the latest published dartdoc is... So we should be good to reland this now, but it will require a bunch of updates for new API since it originally landed plus the bugs @jason-simmons mentioned already |
This reverts commit 6f19a3e. Attempts to resolve merge conflicts and update modified/newly added methods, and fixes the incorrect argument counts on some of the Path methods.
4 participants
Reverts #29607
Possibly tickling a bug in dartdoc:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20docs_test/10286/overview