Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove unused iOS and macOS podspecs #33115

Merged
fluttergithubbot merged 1 commit into from
May 10, 2022
Merged

Remove unused iOS and macOS podspecs #33115

fluttergithubbot merged 1 commit into from
May 10, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 4, 2022 •
edited
Loading

The iOS and macOS podspecs are unused by the framework since flutter/flutter#72020 and flutter/flutter#70224 respectively. Remove them from the engine.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this May 4, 2022
chinmaygarde
chinmaygarde approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure looks related. Possibly a recipe update is necessary. But the PR looks good to me!

@jmagman
Copy link
Member Author

jmagman commented May 5, 2022

The failure looks related. Possibly a recipe update is necessary. But the PR looks good to me!

Yes, I'm on it, I got stuck trying to get the right version of python on my M1 that can run git cl to put out a recipe change... Please hold. 🙂

@jmagman
Copy link
Member Author

jmagman commented May 9, 2022

(This is still on my radar, I'll circle back soon)

@jmagman
Copy link
Member Author

jmagman commented May 10, 2022

Recipe change @ https://flutter-review.googlesource.com/c/recipes/+/29840

@jmagman jmagman added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 10, 2022
@fluttergithubbot fluttergithubbot merged commit 322e595 into flutter:main May 10, 2022
@jmagman jmagman deleted the podspec branch May 10, 2022 22:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 10, 2022
@engine-flutter-autoroll
322e595 Remove unused iOS and macOS podspecs (flutter/engine#33115)
c399cb4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios platform-macos waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @chinmaygarde @fluttergithubbot