This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Hardware Keyboard: Android #33113
Merged
Hardware Keyboard: Android #33113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkwingsmt
force-pushed
the
android-key-embedder-responder
branch
from
80608c7 to
16834f3
Compare
…/engine into android-key-embedder-responder
dkwingsmt
changed the title
8 tasks
Contributor
|
Looks like there are some test failures in |
shell/platform/android/io/flutter/embedding/android/KeyData.java
Outdated
Show resolved
Hide resolved
shell/platform/android/io/flutter/embedding/android/KeyEmbedderResponder.java
Outdated
Show resolved
Hide resolved
shell/platform/android/io/flutter/embedding/android/KeyEmbedderResponder.java
Outdated
Show resolved
Hide resolved
shell/platform/android/io/flutter/embedding/android/KeyEmbedderResponder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Greg Spencer <[email protected]>
…r' into android-key-embedder-responder
Contributor
Author
|
@gspencergoog I've fixed the issues. Can you take another look? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 20, 2022
dkwingsmt
added a commit
that referenced
this pull request
May 20, 2022
This reverts commit 8bf69d1.
dkwingsmt
added a commit
that referenced
this pull request
May 20, 2022
8 tasks
8 tasks
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
* Impl * First test passed * Runnable and more tests * Use constants * static import * modifier keys * nonUsKeys * order test, duplicate/abrupt test * Synthesize pressing keys * WIP * New sync algorithm * Sync with synonym * Add all pressing goals and mask constants * Test all modifiers * Add tests for capslock * Gen * Docs * mutable * Extract CharacterCombiner, docs * doc * License * Doc for keydata * Apply suggestions from code review Co-authored-by: Greg Spencer <[email protected]> * Use & * Format * Fix tests Co-authored-by: Greg Spencer <[email protected]>
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
This reverts commit 8bf69d1.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the embedder keyboard responder of the Android embedding, the backend of
HardwareKeyboardon Android. This is the last platform to support it.The behaviors are tested on a ChromeOS over ARC++. There are some weird behaviors, mostly for
metaState, which I'm not sure is the fault of ARC++ or Android. I don't have an Android device with keyboard to test for now. Therefore the synchronization logic is implemented in a loose way.There are a few known issues:
The framework PR flutter/flutter#104032 generates the necessary codes for this PR.
Related Issues
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.