Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add archives to //flutter build file. #33088

Merged
fluttergithubbot merged 2 commits into from
May 4, 2022
Merged

Add archives to //flutter build file. #33088

fluttergithubbot merged 2 commits into from
May 4, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented May 4, 2022

This is to be able to call the archive artifacts.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Add archives to //flutter build file.
37874a2 
This is to be able to call the archive artifacts.
@godofredoc godofredoc requested review from dnfield and zanderso May 4, 2022 02:43
zanderso
zanderso reviewed May 4, 2022
View reviewed changes
BUILD.gn Outdated
}
}

group("archives") {
Copy link
Member

@zanderso zanderso May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be guarded by build_engine_artifacts.

Copy link
Contributor Author

@godofredoc godofredoc May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 4, 2022
@fluttergithubbot fluttergithubbot merged commit 84d3539 into main May 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 4, 2022
@engine-flutter-autoroll
84d3539 Add archives to //flutter build file. (flutter/engine#33088)
e4b5c83
@cbracken cbracken deleted the fix_v2_builds branch May 27, 2022 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@zanderso zanderso zanderso left review comments

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@godofredoc @zanderso @dnfield @fluttergithubbot