This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix condition in OpacityLayer where it inherits opacity twice #33085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyHillers
approved these changes
May 3, 2022
Contributor
CaseyHillers
left a comment
CaseyHillers
left a comment
There was a problem hiding this comment.
RSLGTM.
Is there a test we can add to verify it?
flar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 4, 2022
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
May 4, 2022
CaseyHillers
pushed a commit
that referenced
this pull request
May 4, 2022
…acity twice (#33085) (#33105) Co-authored-by: Jim Graham <[email protected]>
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
May 6, 2022
…acity twice (flutter#33085) (flutter#33105) Co-authored-by: Jim Graham <[email protected]>
CaseyHillers
pushed a commit
that referenced
this pull request
May 6, 2022
…33169) * [flutter_releases] Fix condition in OpacityLayer where it inherits opacity twice (#33085) (#33105) Co-authored-by: Jim Graham <[email protected]> * [flutter_releases] Remove reference to FX_LOG_ALL (#33027) (#33147) It was partially removed in https://fuchsia-review.googlesource.com/c/fuchsia/+/674049; this commit allows remaining references to be removed. Co-authored-by: Tamir Duberstein <[email protected]> Co-authored-by: Jim Graham <[email protected]> Co-authored-by: Tamir Duberstein <[email protected]>
muditatandon
pushed a commit
to muditatandon/engine
that referenced
this pull request
May 9, 2022
…lutter#33169) * [flutter_releases] Fix condition in OpacityLayer where it inherits opacity twice (flutter#33085) (flutter#33105) Co-authored-by: Jim Graham <[email protected]> * [flutter_releases] Remove reference to FX_LOG_ALL (flutter#33027) (flutter#33147) It was partially removed in https://fuchsia-review.googlesource.com/c/fuchsia/+/674049; this commit allows remaining references to be removed. Co-authored-by: Tamir Duberstein <[email protected]> Co-authored-by: Jim Graham <[email protected]> Co-authored-by: Tamir Duberstein <[email protected]>
8 tasks
muditatandon
added a commit
that referenced
this pull request
May 9, 2022
…33169) (#33222) * [flutter_releases] Fix condition in OpacityLayer where it inherits opacity twice (#33085) (#33105) Co-authored-by: Jim Graham <[email protected]> * [flutter_releases] Remove reference to FX_LOG_ALL (#33027) (#33147) It was partially removed in https://fuchsia-review.googlesource.com/c/fuchsia/+/674049; this commit allows remaining references to be removed. Co-authored-by: Tamir Duberstein <[email protected]> Co-authored-by: Jim Graham <[email protected]> Co-authored-by: Tamir Duberstein <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Jim Graham <[email protected]> Co-authored-by: Tamir Duberstein <[email protected]>
CaseyHillers
pushed a commit
that referenced
this pull request
May 11, 2022
* [flutter_releases] Apply flutter-2.13 candidate.7 CPs to latest roll (#33169) * [flutter_releases] Fix condition in OpacityLayer where it inherits opacity twice (#33085) (#33105) Co-authored-by: Jim Graham <[email protected]> * [flutter_releases] Remove reference to FX_LOG_ALL (#33027) (#33147) It was partially removed in https://fuchsia-review.googlesource.com/c/fuchsia/+/674049; this commit allows remaining references to be removed. Co-authored-by: Tamir Duberstein <[email protected]> Co-authored-by: Jim Graham <[email protected]> Co-authored-by: Tamir Duberstein <[email protected]> * Fix SparseArray lookup in PlatformViewsController (#32947) Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Jim Graham <[email protected]> Co-authored-by: Tamir Duberstein <[email protected]> Co-authored-by: Emmanuel Garcia <[email protected]>
muditatandon
added a commit
to muditatandon/engine
that referenced
this pull request
May 13, 2022
…lutter#33169) (flutter#33222) * [flutter_releases] Fix condition in OpacityLayer where it inherits opacity twice (flutter#33085) (flutter#33105) Co-authored-by: Jim Graham <[email protected]> * [flutter_releases] Remove reference to FX_LOG_ALL (flutter#33027) (flutter#33147) It was partially removed in https://fuchsia-review.googlesource.com/c/fuchsia/+/674049; this commit allows remaining references to be removed. Co-authored-by: Tamir Duberstein <[email protected]> Co-authored-by: Jim Graham <[email protected]> Co-authored-by: Tamir Duberstein <[email protected]> Co-authored-by: Casey Hillers <[email protected]> Co-authored-by: Jim Graham <[email protected]> Co-authored-by: Tamir Duberstein <[email protected]>
8 tasks
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
May 16, 2022
…acity twice (flutter#33085) (flutter#33105) Co-authored-by: Jim Graham <[email protected]>
CaseyHillers
pushed a commit
that referenced
this pull request
May 16, 2022
…acity twice (#33085) (#33105) (#33399) Co-authored-by: Jim Graham <[email protected]> Co-authored-by: Jim Graham <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem found by code reading that will likely fix a problem encountered during an upstream roll.