This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Skip LayerTree::Preroll LayerTree::Paint & Swapbuffer when fr… #33058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I plan on investigating this more and see why frame timing metrics are affected by this. |
Contributor
Author
…ame_damage is empty (flutter#32351)" This reverts commit 5b81baa.
iskakaushik
force-pushed
the
rev-skip-layer-tree
branch
from
528cef4 to
2ee1599
Compare
dnfield
approved these changes
May 2, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 3, 2022
… when frame_damage is empty (flutter#32351)" (flutter/engine#33058)
Member
|
Was this ever investigated / relanded? Also the original PR author should have been cc'd on the revert. @linxuebin1990 |
Member
@zanderso @iskakaushik What does "b/230416004" mean ? I am very interested for this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ame_damage is empty (#32351)"
This reverts commit 5b81baa.
See b/230416004