This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add support for API that accepts float opacity from framework scene builder #33035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 29, 2022 22:55
This was referenced May 1, 2022
added 2 commits
May 2, 2022 12:37
added 4 commits
May 2, 2022 13:20
…e into actual_opacity_layer
jonahwilliams
commented
May 2, 2022
|
|
||
| TEST_F(OpacityLayerTest, Readback) { | ||
| auto initial_transform = SkMatrix(); | ||
| auto layer = std::make_shared<OpacityLayer>(kOpaque_SkAlphaType, SkPoint()); |
Contributor
Author
There was a problem hiding this comment.
I think this was supposed to be SK_AlphaOPAQUE and not kOpaque_SkAlphaType
added 3 commits
May 2, 2022 14:28
Contributor
Author
|
Only current failures appear to be a network exception from some android tests, will try re-running in a bit |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the framework to provide a double for opacity instead of just an alpha. This is implemented as a soft-breaking change, and pushOpacityValue will eventually become pushOpacity
More context: flutter/flutter#102687 and flutter/flutter#102888