Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@bdero
Copy link
Member

@bdero bdero commented Apr 30, 2022

skia-flutter-autoroll and others added 2 commits April 29, 2022 22:54
https://skia.googlesource.com/skia.git/+log/294aaf945757..c987606ad283

2022-04-29 [email protected] Roll emsdk to 3.1.9
2022-04-29 [email protected] Revert "Reland "[includes] Remove SkColorSpace include from SkImageInfo""
2022-04-29 [email protected] [experimental] Add runtime effects to WebGPU demo
2022-04-29 [email protected] [experimental] Update WebGPU/Bazel demo
2022-04-29 [email protected] Manual roll Dawn from 7098d3d69282 to cede544df34f (38 revisions)
2022-04-29 [email protected] Roll SK Tool from d568b1e2748e to 4a9fb9cfed2c
2022-04-29 [email protected] Fix bug where SkQP test that are always to be excluded are not.
2022-04-29 [email protected] Reland "Reland "Add anisotropic option to SkSamplingOptions.""
2022-04-29 [email protected] [bazel] Add shims to help translation into G3
2022-04-29 [email protected] Fix fiddles that use backEndTexture and backEndTextureRenderTarget
2022-04-29 [email protected] [graphite] Check for texture binding state changes in draw pass
2022-04-29 [email protected] Remove InlineMarker IR node.
2022-04-29 [email protected] Roll vulkan-deps from c9e605688988 to 88693e6bf86c (3 revisions)
2022-04-29 [email protected] SkPicturePlayback uses a versioned SkReadBuffer
2022-04-29 [email protected] [ganesh][dawn] Support blocking on async WebGPU events in WASM
2022-04-29 [email protected] Update to newer LLVM for Windows builds
2022-04-29 [email protected] Disable no-declaration-after-statement
2022-04-29 [email protected] [includes] Enforce IWYU on //example
2022-04-29 [email protected] Fix -Wunused-but-set-variable warnings
2022-04-29 [email protected] [graphite] Add support for the ImageShader's local matrix
2022-04-29 [email protected] Make program link errors non-fatal when using cached binaries
2022-04-29 [email protected] Reland "[includes] Remove SkColorSpace include from SkImageInfo"
2022-04-29 [email protected] Revert "Reland "Add anisotropic option to SkSamplingOptions.""
2022-04-29 [email protected] [graphite] Add 565 format support
2022-04-29 [email protected] Reland "Add anisotropic option to SkSamplingOptions."
2022-04-29 [email protected] [infra] Remove Win7 fyi jobs
2022-04-29 [email protected] [bazel] Point to vk_mem_alloc from DEPS
2022-04-29 [email protected] Specify VMA include relative to source root
2022-04-29 [email protected] Roll SwiftShader from b92f7acb7e81 to adef92e7b4c6 (4 revisions)
2022-04-29 [email protected] Roll ANGLE from f9729598a6a0 to 2c58e7a5bab7 (2 revisions)
2022-04-29 [email protected] Roll Chromium from 8b65ae5339f2 to 2aa54824f810 (514 revisions)
2022-04-29 [email protected] Roll vulkan-deps from 62a883c73abb to c9e605688988 (1 revision)
2022-04-28 [email protected] Use DEPS to pull in VulkanMemoryAllocator.
2022-04-28 [email protected] Revert "[includes] Remove SkColorSpace include from SkImageInfo"
2022-04-28 [email protected] Avoid String::printf on a hot path.
2022-04-28 [email protected] Remove recursion checks from inliner.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@bdero
Copy link
Member Author

bdero commented Apr 30, 2022

Image-related DisplayList ops have an SkSamplingOptions. Skia added a maxAniso field to SkSamplingOptions which is 4 bytes, but ops in DisplayLists are 8-byte aligned, and so the final size of the affected test DisplayLists increased by 8 bytes.

We can add support for inspecting this new field in the relevant classes later. Supporting this setting in Impeller would also be trivial. :)

Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skia roll breaking displaylist tests

4 participants