This repository was archived by the owner on Feb 25, 2025. It is now read-only.
WinUWP: Remove UWP support from gn wrapper #33016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the --winuwp option from the Flutter gn wrapper script, eliminating the winuwp configurations. UWP-specific code and build targets will be removed in followup patches. Tool support was removed in: flutter/flutter#102174 CI target was removed in: #33012 Build recipe was removed in: https://flutter-review.googlesource.com/c/recipes/+/29500 Issue: flutter/flutter#102172
cbracken
added
the
waiting for tree to go green
8 tasks
cbracken
added a commit
that referenced
this pull request
Apr 30, 2022
This removes: * The Windows UWP emebedder sources and targets * UWP-specific build targets * UWP-specific code behind WINUWP #ifdefs * UWP-specific TODOs. * uwptool.exe sources and targets used for installing, uninstalling, and launching UWP apps. This is a straight removal patch, and does not land any refactorings made possible by removal of UWP support. Those patches will land in followup refactorings. Tool support was removed in: flutter/flutter#102174 The CI target was removed in: #33012 The Recipe was removed in: https://flutter-review.googlesource.com/c/recipes/+/29500 GN build support was removed in: #33016 Issue: flutter/flutter#102172
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the --winuwp option from the Flutter gn wrapper script,
eliminating the winuwp configurations. UWP-specific code and build
targets will be removed in followup patches.
Tool support was removed in:
flutter/flutter#102174
CI target was removed in:
#33012
Build recipe was removed in:
https://flutter-review.googlesource.com/c/recipes/+/29500
Issue: flutter/flutter#102172
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.