Add vulkanmemoryallocator dependency for Skia; roll Skia to 4230297004 #33008
Conversation
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
It looks like the license check will need to be taught to skip some of the new files
|
License script is past the initial failure -- amending the previously broken roll to this PR. |
|
Ugh, local build on macos host_debug_unopt is successful for me. |
bdero
force-pushed
the
bdero/vma-skia-dep
branch
from
b9c2b68 to
f38974c
Compare
|
The license script reordered a few things. My diff tool is smart enough to see it's not the entire |
bdero
force-pushed
the
bdero/vma-skia-dep
branch
2 times, most recently
from
1448c97 to
b36fe7d
Compare
tools/licenses/lib/main.dart
Outdated
| return _RepositoryPkgDirectory(this, entry); | ||
| if (entry.name == 'vulkan') | ||
| return _RepositoryVulkanDirectory(this, entry); | ||
| if (!entry.fullName.endsWith('externals/vulkanmemoryallocator')) |
There was a problem hiding this comment.
Should this condition be the opposite? That is, if it does end with the string, then we do want to return _RepositoryVulkanMemoryAllocatorDirectory?
bdero
force-pushed
the
bdero/vma-skia-dep
branch
from
b36fe7d to
2a0b22d
Compare
https://skia.googlesource.com/skia.git/+log/294aaf945757..3b51120a92aa 2022-04-28 [email protected] Use DEPS to pull in VulkanMemoryAllocator. 2022-04-28 [email protected] Revert "[includes] Remove SkColorSpace include from SkImageInfo" 2022-04-28 [email protected] Avoid String::printf on a hot path. 2022-04-28 [email protected] Remove recursion checks from inliner. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bdero
force-pushed
the
bdero/vma-skia-dep
branch
from
7ff8e10 to
4980340
Compare
bdero
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
3 participants
Fixes flutter/flutter#102806.
Should unblock the roll once https://skia-review.googlesource.com/c/skia/+/535356 lands.