This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Display list test executables #32973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Apr 27, 2022
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Splitting this out of the flow unit-tests harness makes a lot of sense. However, you don't really need to split it out into two harnesses just to separate out the slow tests. You could tag the slow ones with a specific prefix and use a gtest_filter to selectively suppress running them. Either way, lgtm.
Contributor
Author
The rendertests aren't really unit tests. It's the same reason we split out the benchmarks..? |
flar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the flow_unittests take a really long time to run, mostly because they contain the display_list_canvas_unittests tests which take 40 seconds per run.
The fact that DisplayList code is tested under the "flow" suite is also someone odd as it really is a different module in the code.
This PR breaks the DisplayList tests out of the flow tests and makes 2 new executables for them. The first is just the basic unit tests under display_list_unittests and the second is the long running dl_canvas_unittests which are now in their own executable display_list_rendertests.