This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Android, Keyboard] Extract KeyboardManager's external dependencies as ViewDelegate; Rework testing framework #32944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
From PR triage: @dkwingsmt is this PR ready for review or is it still WIP? |
Contributor
Author
|
@zanderso This PR is almost ready for review, after I add a few documentations. But the reviewer is out this week so I'll have to wait until the next week. |
gspencergoog
approved these changes
May 4, 2022
Contributor
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 4, 2022
…encies as ViewDelegate; Rework testing framework (flutter/engine#32944)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2022
…encies as ViewDelegate; Rework testing framework (flutter/engine#32944)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2022
…encies as ViewDelegate; Rework testing framework (flutter/engine#32944)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2022
…encies as ViewDelegate; Rework testing framework (flutter/engine#32944)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR makes
KeyboardManageran all-in-one component that encapsulates the entire keyboard system, and reworks the testing framework to support such changes.All of
KeyboardManager's external dependencies are now extracted asKeyboardManager.ViewDelegate, which is implemented byFlutterView. The keyboard responders are now created and managed by the manager, instead of the view. In this way, the view is no longer aware of any implementation details, but only what the manager needs from outside. Moreover, what's needed forKeyboardManagerbyInputConnectionAdaptorhas also been extracted as a delegate.Moreover, the testing framework has been reworked. The new framework mocks and compares the end result of the manager's effects, i.e. the engine and the messenger. It also adopts the latest "class-based" design.
As a non-trivial change, the channel message no longer provides
vendorIdandproductId. Mocking them is a little harder under the new test framework, and they're likely not used much, and are expected to be removed inKeyEventanyway.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.