iOS spell-checker ObjC #32941

cyanglaz · 2022-04-26T23:08:00Z

Adds SpellCheck Objective C code in engine. This is part of flutter/flutter#34688

The PR can be landed standalone, it does not affect or add features to the current Flutter.

This PR adds a FlutterSpellCheckPlugin to FlutterEngine. This plugin uses a method channel to communicate with dart. The plugin currently has one method: SpellCheck.initiateSpellCheck, which looks for the first misspelled word in the argument String and returns a result map:

{
   @"startIndex": 0,
   @"endIndex" : 5,
   @"suggestions": [@"suggestion1", @"suggestion2"..]
 }

Design doc: https://docs.google.com/document/d/10Lvkz802QpzAGFi3Q9WVTMVUV-SPJyG3_xs8XfxG59Q/edit?usp=sharing

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2022-04-27T00:51:41Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

  _binaryMessenger.parent = nil;
  [_binaryMessenger release];
  [_isolateId release];
+  [self.flutterSpellCheckPlugin release];


Don't reference self in dealloc.

jmagman · 2022-04-27T00:53:30Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+#import <UIKit/UIApplication.h>
+#import <UIKit/UIKit.h>
+
+#include "flutter/fml/logging.h"


Any idea why we ever #include instead of #import in the darwin shell?

jmagman · 2022-04-27T00:55:20Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+- (instancetype)initWithMethodChannel:(FlutterMethodChannel*)methodChannel {
+  self = [super init];
+  if (self) {
+    [self.methodChannel setMethodCallHandler:^(FlutterMethodCall* call, FlutterResult result) {


Same here, set the backing ivar instead of using self property getter in an initializer

jmagman · 2022-04-27T00:56:25Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+//   @"endIndex" : 5,
+//   @"suggestions": [@"suggestion1", @"suggestion2"..]
+// }
+- (NSDictionary*)kInitiateSpellCheck:(id)args {


Don't match the static NSString constant.

Suggested change

- (NSDictionary*)kInitiateSpellCheck:(id)args {

- (NSDictionary*)initiateSpellCheck:(id)args {

jmagman · 2022-04-27T00:59:25Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+                                           startingAt:0
+                                                 wrap:NO
+                                             language:language];
+  if (misspelledRange.length <= 0) {


I think it's more idiomatic to check for location != NSNotFound but length != 0 is fine too. You don't need <=0 since length is a NSUInteger though.

jmagman · 2022-04-27T01:00:07Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+}
+
+- (void)dealloc {
+  [self.textChecker release];


Suggested change

[self.textChecker release];

[_textChecker release];

jmagman · 2022-04-27T01:05:10Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+//   @"suggestions": [@"suggestion1", @"suggestion2"..]
+// }
+- (NSDictionary*)kInitiateSpellCheck:(id)args {
+  NSString* language = args[0];


Should this check if this is in availableLanguages and either bail if not, or allow nil and fall back to the first availableLanguages preference? Doc says https://developer.apple.com/documentation/uikit/uitextchecker/1621033-availablelanguages?language=objc

An array of strings representing ISO 639-1 language codes or combined ISO 639-1 language codes and ISO 3166-1 regional codes (for example, en_US).

Yes. we should check this.
I prefer bailing rather than assuming a language for the user.

Actually, I can do some tests with an "unavailable" language and see what the return values are for rangeOfMisspelledWordInString. the result might just be as the same as bailing.

The return value is (0, 0), so using a "unsupported" language is the same as "there is no spell checking error", which seems make sense to me.

The worry is that it makes harder for user to notice if they use a "unsupported" language. I think it is still necessary for us to check for it, and return an error in the method channel.

Update:
No suggestions now returns an empty array
Unsupported language now returns nil.

jmagman

Nits, LGTM

jmagman · 2022-04-28T22:29:01Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

-    result([self initiateSpellCheck:args]);
+    FlutterError* error;
+    NSDictionary* spellCheckResult = [self initiateSpellCheck:args withError:&error];
+    if (error) {


It's more idiomatic in Objective-C to check if the return value is nil, and then process the error.

A returned nil value is valid without an error in our case here: that is when spell-check didn't find a misspelled word.
So if we check nil first, it will be:

if (! spellCheckResult && error) { ... } else { ... }

That's essentially the same with an extra unnecessary check.

Or maybe initiateSpellCheck: should return something else to indicate a spell check didn't find a misspelled word?

Since NSNotFound is not defined by us, it would be error prone to return NSNotFound to dart and rely on that. Maybe we can use -1 as the startingIndex when no misspelled word is found? So:

{ startIndex: -1 endIndex: -1 suggestions: [] }

This way, initiateSpellCheck: only returns nil when there's an error, which better matches Objective-C idiomatic. WDYT

A returned nil value is valid without an error in our case here: that is when spell-check didn't find a misspelled word.

Can we make that case return an empty dictionary instead?

Yes, I will change it to empty array as we are changing this API to return all the spell errors.

jmagman · 2022-04-28T22:30:01Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPluginTest.mm

+                                  capturedResult = result;
+                                }];
+  XCTAssertTrue([capturedResult isKindOfClass:[FlutterError class]]);
+  XCTAssertEqual(((FlutterError*)capturedResult).code, @"unsupported_language");


Suggested change

XCTAssertEqual(((FlutterError*)capturedResult).code, @"unsupported_language");

XCTAssertEqualObjects((FlutterError*)capturedResult).code, @"unsupported_language");

jmagman · 2022-04-28T22:30:49Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+//   @"endIndex" : 5,
+//   @"suggestions": [@"suggestion1", @"suggestion2"..]
+// }
+- (NSDictionary*)initiateSpellCheck:(id)args withError:(FlutterError**)error {


Suggested change

- (NSDictionary*)initiateSpellCheck:(id)args withError:(FlutterError**)error {

- (NSDictionary<NSString *, id>*)initiateSpellCheck:(id)args withError:(FlutterError**)error {

Actually this name is kind of confusing, it's not like it's kicking off a spell check to be processed later.

How about something like spellCheckSuggestionsForText:inLanguage:withError: where the arg indexing happens one layer up?

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

chinmaygarde · 2022-05-05T20:05:05Z

@jmagman has open questions and suggestions. @cyanglaz Any progress on this PR?

cyanglaz · 2022-05-05T20:24:58Z

@chinmaygarde Thank you for the reminder:) I switched my attention and started banging my head on flutter/flutter#103076 as it has a higher priority. I will circle back to this PR once I have some progress on the other issue.

cyanglaz

@jmagman Updated to return all spell check errors in the String.
PTAL

cyanglaz · 2022-05-06T18:34:52Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

-    result([self initiateSpellCheck:args]);
+    FlutterError* error;
+    NSDictionary* spellCheckResult = [self initiateSpellCheck:args withError:&error];
+    if (error) {


Yes, I will change it to empty array as we are changing this API to return all the spell errors.

cyanglaz · 2022-05-09T18:16:47Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+//   @"suggestions": [@"suggestion1", @"suggestion2"..]
+// }
+- (NSDictionary*)kInitiateSpellCheck:(id)args {
+  NSString* language = args[0];


Update:
No suggestions now returns an empty array
Unsupported language now returns nil.

jmagman · 2022-05-10T01:10:57Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

+  self.flutterSpellCheckPlugin =
+      [[[FlutterSpellCheckPlugin alloc] initWithMethodChannel:_spellCheckChannel.get()] retain];


❌ Failures for clang-tidy on /opt/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm: /opt/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm:592:1: error: Potential leak of an object of type 'FlutterSpellCheckPlugin *' [clang-analyzer-osx.cocoa.RetainCount,-warnings-as-errors] } ^ /opt/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm:528:7: note: Assuming the condition is false if ([_initialRoute length] > 0) { ^~~~~~~~~~~~~~~~~~~~~~~~~~ /opt/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm:528:3: note: Taking false branch if ([_initialRoute length] > 0) { ^ /opt/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm:591:8: note: Method returns an instance of FlutterSpellCheckPlugin with a +1 retain count [[[FlutterSpellCheckPlugin alloc] initWithMethodChannel:_spellCheckChannel.get()] retain]; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /opt/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm:591:7: note: Reference count incremented. The object now has a +2 retain count [[[FlutterSpellCheckPlugin alloc] initWithMethodChannel:_spellCheckChannel.get()] retain]; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /opt/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm:592:1: note: Object leaked: allocated object of type 'FlutterSpellCheckPlugin *' is not referenced later in this execution path and has a retain count of +2 }

jmagman · 2022-05-10T01:12:03Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+#import "flutter/shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.h"
+
+#import <Foundation/Foundation.h>
+#import <UIKit/UIApplication.h>


Suggested change

#import <UIKit/UIApplication.h>

This is already imported with #import <UIKit/UIKit.h>

jmagman · 2022-05-10T01:13:18Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+  self = [super init];
+  if (self) {
+    [_methodChannel setMethodCallHandler:^(FlutterMethodCall* call, FlutterResult result) {
+      [self handleMethodCall:call result:result];


I guess this isn't a retain cycle in MRC since it doesn't increase the retain count. Does it need to check if self is nil? Brain hurts.

Good catch! We should check if self is nil.

jmagman · 2022-05-10T01:30:23Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPluginTest.mm

+                              startingAt:(NSInteger)startingOffset
+                                    wrap:(BOOL)wrapFlag
+                                language:(NSString*)language {
+  return self.startingIndexToRange[@(startingOffset)].rangeValue;


NSRangeFromString is already a thing.

jmagman · 2022-05-10T01:33:13Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+  FML_DCHECK([UITextChecker.availableLanguages containsObject:language]);
+  NSRange misspelledRange =
+      [self.textChecker rangeOfMisspelledWordInString:text
+                                                range:NSMakeRange(0, text.length)


Does this API handle empty/nil strings?

It handles empty String, which I added a test for.
We won't get a nil here as I have added some assert above.

jmagman · 2022-05-10T01:33:29Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPluginTest.mm

+  NSArray* suggestions1 = @[ @"suggestion 1", @"suggestion 2" ];
+  NSArray* suggestions2 = @[ @"suggestion 3", @"suggestion 4" ];
+  [self mockUITextCheckerWithExpectedMisspelledWordRange:NSMakeRange(0, 5)


It seems like you're mostly testing out your mocks here. Are you sure it's thoroughly testing the corner cases of the range math, like the last part of the string being misspelled, that every letter is included in the ranges, empty strings?

like the last part of the string being misspelled
Example: "This is missspelled" where the last word is being tested.

that every letter is included in the ranges
Example "missspelled" where the entire string is one misspelled word.

Offline discussion: we need one more test to check the while loop stops when nextStartingIndex is out of bounds.

jmagman · 2022-05-10T01:35:32Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+      nextOffset = [nextSpellSuggestion[@"location"] integerValue] +
+                   [nextSpellSuggestion[@"length"] integerValue];


These are NSUIntegers.

jmagman · 2022-05-10T01:36:17Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+  result[@"location"] = @(misspelledRange.location);
+  result[@"length"] = @(misspelledRange.length);


Instead of splitting the range you can use NSValue, see valueWithRange:. Or better, create a new object with range and suggestions properties? Or a dictionary with the NSValue as a key and the suggestions. The string keys needed between two methods seems unnecessary.

jmagman · 2022-05-16T21:33:54Z

Friendly ping @cyanglaz to check out the clang-tidy complaint.

cyanglaz · 2022-05-17T20:04:02Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+  NSString* method = call.method;
+  NSArray* args = call.arguments;
+  if ([method isEqualToString:kInitiateSpellCheck]) {
+    FML_DCHECK(args.count == 2);


Assert both fields cannot be nil.
They can still be NSNull if dart passes null to this method channel. I added a bail below when either of them is NSNull

cyanglaz · 2022-05-17T20:04:32Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+  FML_DCHECK([UITextChecker.availableLanguages containsObject:language]);
+  NSRange misspelledRange =
+      [self.textChecker rangeOfMisspelledWordInString:text
+                                                range:NSMakeRange(0, text.length)


It handles empty String, which I added a test for.
We won't get a nil here as I have added some assert above.

cyanglaz

@jmagman Updated, ptal

cyanglaz · 2022-05-18T23:08:55Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPluginTest.mm

+  NSArray* suggestions1 = @[ @"suggestion 1", @"suggestion 2" ];
+  NSArray* suggestions2 = @[ @"suggestion 3", @"suggestion 4" ];
+  [self mockUITextCheckerWithExpectedMisspelledWordRange:NSMakeRange(0, 5)


Offline discussion: we need one more test to check the while loop stops when nextStartingIndex is out of bounds.

cyanglaz · 2022-05-18T23:11:30Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+      nextOffset =
+          nextSpellSuggestion.misspelledRange.location + nextSpellSuggestion.misspelledRange.length;
+    }
+  } while (nextSpellSuggestion != nil && nextOffset < text.length);


nextOffset < text.length :)

jmagman · 2022-05-18T23:12:36Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPluginTest.mm

+// stop if nsnotfound
+
+// if the startingIndex is last
+
+// Test to make sure the while loop that checks all the misspelled word stops when the a
+// `NSNotFound` is found.


Probably didn't mean to leave this in 🙂

I didn't mean to leave the first 2 lines in but i want to leave the "Test to make sure.." in. This serves as a little explanation to the test as what logic is the test testings.

jmagman · 2022-05-18T23:19:05Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+                            suggestions:(NSArray<NSString*>*)suggestions {
+  self = [super init];
+  if (self) {
+    _suggestions = suggestions;


Suggested change

_suggestions = suggestions;

_suggestions = [suggestions copy];

jmagman · 2022-05-19T00:02:57Z

shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm

+  result[@"location"] = @(_misspelledRange.location);
+  result[@"length"] = @(_misspelledRange.length);
+  result[@"suggestions"] = [_suggestions copy];
+  return result;


❌ Failures for clang-tidy on /opt/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm:
/opt/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm:159:3: error: Potential leak of an object of type 'id' [clang-analyzer-osx.cocoa.RetainCount,-warnings-as-errors]
return result;
^~~~~~~~~~~~~
/opt/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm:158:28: note: Method returns an Objective-C object with a +1 retain count
result[@"suggestions"] = [_suggestions copy];
^~~~~~~~~~~~~~~~~~~
/opt/s/w/ir/cache/builder/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSpellCheckPlugin.mm:159:3: note: Object leaked: allocated object of type 'id' is not referenced later in this execution path and has a retain count of +1
return result;
^~~~~~~~~~~~~

draft spellcheck objc review throw error if language is not supported run spell check to the end of the string convert to use scoped_nsobject to match other plugins some review fixes review clang-tidy, remove unnecessary comments

dnfield · 2022-05-23T22:46:43Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

+  _spellCheckChannel.reset([[FlutterMethodChannel alloc]
+         initWithName:@"flutter/spellcheck"
+      binaryMessenger:self.binaryMessenger
+                codec:[FlutterJSONMethodCodec sharedInstance]]);


drive by: new codecs should avoid using the JSON codec.

What codec should be used?

FlutterStandardMethodCodec

This reverts commit cba7bf3.

flutter-dashboard bot added the platform-ios label Apr 26, 2022

cyanglaz requested review from camsim99 and jmagman April 26, 2022 23:09

jmagman reviewed Apr 27, 2022

View reviewed changes

jmagman approved these changes Apr 28, 2022

View reviewed changes

cyanglaz commented May 9, 2022

View reviewed changes

cyanglaz force-pushed the ios_spell_check branch from 52e8f75 to 35ab1a7 Compare May 9, 2022 20:14

jmagman reviewed May 10, 2022

View reviewed changes

cyanglaz force-pushed the ios_spell_check branch from 35ab1a7 to 0cca3e9 Compare May 17, 2022 17:36

cyanglaz commented May 17, 2022

View reviewed changes

cyanglaz commented May 18, 2022

View reviewed changes

jmagman reviewed May 19, 2022

View reviewed changes

jmagman approved these changes May 19, 2022

View reviewed changes

drafgit st

18669dd

draft spellcheck objc review throw error if language is not supported run spell check to the end of the string convert to use scoped_nsobject to match other plugins some review fixes review clang-tidy, remove unnecessary comments

cyanglaz force-pushed the ios_spell_check branch from 193d247 to 18669dd Compare May 19, 2022 16:25

cyanglaz added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 19, 2022

fluttergithubbot merged commit cba7bf3 into flutter:main May 19, 2022

engine-flutter-autoroll mentioned this pull request May 20, 2022

Roll Flutter Engine from 9685c8122186 to 4b577ebcf84c (17 revisions) flutter/flutter#104227

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2022

cba7bf3 iOS spell-checker ObjC (flutter/engine#32941)

270d3c3

engine-flutter-autoroll mentioned this pull request May 20, 2022

Roll Flutter Engine from 9685c8122186 to 8100b9f295aa (18 revisions) flutter/flutter#104228

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 20, 2022

cba7bf3 iOS spell-checker ObjC (flutter/engine#32941)

766dbac

dnfield reviewed May 23, 2022

View reviewed changes

cyanglaz deleted the ios_spell_check branch May 23, 2022 23:01

cyanglaz pushed a commit that referenced this pull request May 23, 2022

Revert "iOS spell-checker ObjC (#32941)"

bf583b5

This reverts commit cba7bf3.

cyanglaz mentioned this pull request May 23, 2022

Revert "iOS spell-checker ObjC" #33570

Merged

houhuayong pushed a commit to houhuayong/engine that referenced this pull request Jun 21, 2022

iOS spell-checker ObjC (flutter#32941)

2773983

auto-submit bot pushed a commit that referenced this pull request Jul 11, 2022

Reland "iOS spell-checker ObjC #32941" (#34356)

45d0ae7

justinmc mentioned this pull request Oct 24, 2022

Autocorrect tooltips don't appear on iOS flutter/flutter#12920

Open

	- (NSDictionary*)kInitiateSpellCheck:(id)args {
	- (NSDictionary*)initiateSpellCheck:(id)args {

	XCTAssertEqual(((FlutterError*)capturedResult).code, @"unsupported_language");
	XCTAssertEqualObjects((FlutterError*)capturedResult).code, @"unsupported_language");

	- (NSDictionary)initiateSpellCheck:(id)args withError:(FlutterError*)error {
	- (NSDictionary<NSString , id>)initiateSpellCheck:(id)args withError:(FlutterError**)error {

		self.flutterSpellCheckPlugin =
		[[[FlutterSpellCheckPlugin alloc] initWithMethodChannel:_spellCheckChannel.get()] retain];

		nextOffset = [nextSpellSuggestion[@"location"] integerValue] +
		[nextSpellSuggestion[@"length"] integerValue];

		result[@"location"] = @(misspelledRange.location);
		result[@"length"] = @(misspelledRange.length);

	_suggestions = suggestions;
	_suggestions = [suggestions copy];

iOS spell-checker ObjC #32941

iOS spell-checker ObjC #32941

Uh oh!

Conversation

cyanglaz commented Apr 26, 2022

Pre-launch Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cyanglaz Apr 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chinmaygarde commented May 5, 2022

Uh oh!

cyanglaz commented May 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

cyanglaz Apr 27, 2022 •

edited

Loading

cyanglaz commented May 5, 2022 •

edited

Loading

jmagman May 18, 2022 •

edited

Loading