This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Reland "Migrate Flutter Web to JS static interop - 14". #32928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
joshualitt
changed the title
Contributor
Author
|
@srujzs , @eyebrowsoffire ptal. I think I got the only reference to |
Contributor
|
LGTM |
eyebrowsoffire
approved these changes
May 2, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relanding CL 14 in the series to migrate Flutter Web to the new static interop model.
The issue is that
addPopEventStateListenerneeds to wrap the listener inallowInterop. I added a test and confirmed this now passes in integration tests.The revert is here:
#32919