This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add impeller artifacts to artifacts target #32912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Apr 25, 2022
build/archives/BUILD.gn
Outdated
| }, | ||
| { | ||
| source = "$root_out_dir/libtessellator$dll" | ||
| destination = "libtessellator$dll" |
Contributor
There was a problem hiding this comment.
Note for future us: we did something a little strange here and manually prepended lib to the DLL output to avoid a naming clash on Windows with a source_set that otherwise had the same name in Impeller. This has the happy (?) side effect of making the file name without the extension being identical on all platforms.
dnfield
approved these changes
Apr 25, 2022
zanderso
force-pushed
the
add-impeller-artifacts-to-archive
branch
from
25ab755 to
da4408c
Compare
Member
Author
|
This is failing presubmits because the target removed here flutter/buildroot#566 probably needs to be guarded by |
zanderso
force-pushed
the
add-impeller-artifacts-to-archive
branch
from
da4408c to
108269d
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match https://flutter-review.googlesource.com/c/recipes/+/29300