Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@joshualitt
Copy link
Contributor

This is CL 2 in a series of CLs to migrate Flutter Web DOM usage to the new JS static interop API.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added platform-web Code specifically for the web engine needs tests labels Apr 25, 2022
@joshualitt joshualitt force-pushed the html_2 branch 2 times, most recently from 801cb0c to 1bfd654 Compare April 25, 2022 21:39
@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/32910

@joshualitt joshualitt force-pushed the html_2 branch 2 times, most recently from 167ebcc to 17c9873 Compare April 26, 2022 02:17
@joshualitt
Copy link
Contributor Author

@srujzs @eyebrowsoffire ptal. I'm not sure if this is the best way to get a dependent pr reviewed, but please only look at CL 2, or use this link: joshualitt/engine@html_1...joshualitt:html_2

@srujzs
Copy link
Contributor

srujzs commented Apr 26, 2022

LGTM

@Hixie
Copy link
Contributor

Hixie commented Apr 28, 2022

test-exempt: code refactor with no semantic change

@joshualitt
Copy link
Contributor Author

@eyebrowsoffire friendly ping in case this slipped between the cracks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants