This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Disable the timeline in release mode on Android unless systrace is enabled #32909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
force-pushed
the
android_release_timeline
branch
from
1b4fcea to
7abc170
Compare
dnfield
reviewed
Apr 25, 2022
common/settings.h
Outdated
| std::optional<std::vector<std::string>> trace_skia_allowlist; | ||
| bool trace_startup = false; | ||
| bool trace_systrace = false; | ||
| bool disable_timeline_event_handler = false; |
Contributor
There was a problem hiding this comment.
Consider making this enable_timeline_event_handler and defauling it to true (https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-double-negatives-in-apis)
dnfield
approved these changes
Apr 25, 2022
Contributor
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
LGTM with style nit. Thanks for digging through this.
jason-simmons
force-pushed
the
android_release_timeline
branch
from
7abc170 to
0f2b42b
Compare
jason-simmons
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.