This repository was archived by the owner on Feb 25, 2025. It is now read-only.
use new DlObjects throughout the DisplayList code #32896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Apr 28, 2022
Member
|
Rebasing past the Impeller merge ought to resolve the conflicts. |
Contributor
Author
|
Rebasing plus incorporating the Impeller changes to the copies in the engine repo...
|
flar
force-pushed
the
embrace-DlObjects-throughout-DisplayList
branch
from
ede96db to
5080192
Compare
flar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we've been creating DisplayList versions of the Skia objects we've used in our rendering buffers, we haven't always been back-filling their uses into the existing DisplayList source base.
This PR replaces a number of the Sk* objects in the display_list directory (and Impeller) with the new Dl* versions.
Associated Impeller changes: flutter/impeller#157