-
Notifications
You must be signed in to change notification settings - Fork 6k
Update ICU to 71-1 #32879
Update ICU to 71-1 #32879
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The license checker is warning about this roll: |
|
@jason-simmons Thanks. It should be resolved now. PTAL |
|
This is going to break Fuchsia. |
This reverts commit 61124ef.
This reverts commit 24e7c0c.
This updates the ICU library to the latest version. This also updates the license checking scripts as the ICU license has been lightly updated.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.