Reuse the same temporary canvas for creating shader images #32864
Conversation
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
kenrussell
left a comment
kenrussell
left a comment
There was a problem hiding this comment.
This is great! I'm only a bystander, but this change looks good to me.
To have it archived here, it's worth mentioning this was related to Google-internal bug ID 214612687.
eyebrowsoffire
added
the
waiting for tree to go green
4 participants
Instead of creating a new offscreen canvas every time we render the image, just use one shared temporary canvas that is reused whenever needed.