This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Minor unique_ptr initialization cleanup #32821
Merged
+12
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up a few cases of std::unique_ptr(new T) that could have been using std::make_unique<T>(...).
Member
Author
|
Noticed while poking around some Window-related code with @goderbauer this morning. |
chinmaygarde
approved these changes
Apr 20, 2022
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
lgtm as long as it compile 😊. These are usually hard to reason about without looking to see if the ctor is private/protected in the header.
Member
Author
|
There were a few cases (e.g. PersistentCache, where we updated an internal unique_ptr with a new instance of itself) that couldn't be updated for that exact reason, but this should only be the public stuff. |
cbracken
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up a few cases of std::unique_ptr(new T) that could have been
using std::make_unique(...).
No tests since no semantic changes, just object allocation cleanup.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.