[Win32] Eliminate use of OpenGL ES 3.1 symbols #32780
Conversation
In ANGLE commit 232e523656fccfacabeb8e5ce0cbc2e6dcc1ec4e, an Open GL extension API was removed from ANGLE which included several symbols that are not available until OpenGL ES 3.2. This was removed since it had no known users, and cut the number of entrypoints ANGLE exports in half, saving 130kB on Android. Of the removed symbols, the Windows embedder used two: * GL_RGBA8, which is not OpenGL ES, but rather OpenGL, and can be replaced with GL_RGBA which is lenient since it doesn't ask for a specific size. * GL_CLAMP_TO_EDGE, which can be replaced with GL_CLAMP_TO_BORDER. https://open.gl/textures for details. Issue: flutter/flutter#102117
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
/cc @jnschulze (original author of Flutter Win32 texture support) for thoughts. |
|
test-exempt: code refactor with no semantic change to enable dependency roll |
In ANGLE commit 232e523656fccfacabeb8e5ce0cbc2e6dcc1ec4e, an Open GL extension API was removed from ANGLE which included several symbols that are not available until OpenGL ES 3.2. This was removed since it had no known users, and cut the number of entrypoints ANGLE exports in half, saving 130kB on Android. Of the removed symbols, the Windows embedder used two: * GL_RGBA8, which is not OpenGL ES, but rather OpenGL, and can be replaced with GL_RGBA which is lenient since it doesn't ask for a specific size. * GL_CLAMP_TO_EDGE, which can be replaced with GL_CLAMP_TO_BORDER. https://open.gl/textures for details. Issue: flutter/flutter#102117
3 participants
In ANGLE commit 232e523656fccfacabeb8e5ce0cbc2e6dcc1ec4e, an Open GL
extension API was removed from ANGLE which included several symbols that
are not available until OpenGL ES 3.2. This was removed since it had no
known users, and cut the number of entrypoints ANGLE exports in half,
saving 130kB on Android.
Of the removed symbols, the Windows embedder used two:
replaced with GL_RGBA which is lenient since it doesn't ask for a
specific size.
https://open.gl/textures for details.
Issue: flutter/flutter#102117
No test changes since no behavioural changes expected. This is purely to
unblock an ANGLE roll which would otherwise have compile errors.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.