This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux] add FlViewAccessible tests #32769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add construct-only 'engine' property to make it possible to inject a mock engine.
Member
Author
|
Ping @robert-ancell @cbracken |
robert-ancell
approved these changes
May 9, 2022
Contributor
robert-ancell
left a comment
robert-ancell
left a comment
There was a problem hiding this comment.
Other than the small change LGTM.
- drop fl_view_accessible prefix for non-methods - set_engine -> init_engine to make the intention clear
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR complements the accessibility tree tests added in #32499. A prerequisite for the tests is to add a way to inject a mock engine because view instances cannot be created in headless CI.
Pre-launch Checklist
///).