Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Migrate RuntimeEnvironment#sytemContext to ApplicatoinProvider#getApplicationContext #32725

Merged
fluttergithubbot merged 1 commit into from
Apr 18, 2022
Merged

Migrate RuntimeEnvironment#sytemContext to ApplicatoinProvider#getApplicationContext #32725

fluttergithubbot merged 1 commit into from
Apr 18, 2022

Conversation

@utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Apr 16, 2022

RuntimeEnvironment#systemContext was deprecated, and it's recommended to use ApplicationProvider#getApplicationContext.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@utzcoz
Copy link
Contributor Author

utzcoz commented Apr 16, 2022

Hi @zanderso , could you help to review this PR? Thanks.

@jason-simmons jason-simmons requested a review from blasten April 18, 2022 17:12
blasten
blasten approved these changes Apr 18, 2022
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 18, 2022
@fluttergithubbot fluttergithubbot merged commit 3000a4a into flutter:main Apr 18, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 18, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 18, 2022
@engine-flutter-autoroll
3000a4a Migrate RuntimeEnvironment#sytemContext to ApplicatoinProvide…
4ba4a53 
…r#getApplicationContext (flutter/engine#32725)
@utzcoz utzcoz deleted the migrate-RuntimeEnvironment-systemContext branch April 19, 2022 00:01
justinmc pushed a commit to justinmc/engine that referenced this pull request Apr 20, 2022
@utzcoz @justinmc
Migrate RuntimeEnvironment#sytemContext to ApplicatoinProvider#getApp…
8216796 
…licationContext (flutter#32725)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@blasten blasten blasten approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@utzcoz @blasten @jason-simmons @fluttergithubbot