Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add mac_host_engine v2 builder. #32721

Merged
fluttergithubbot merged 1 commit into from
Apr 16, 2022
Merged

Add mac_host_engine v2 builder. #32721

fluttergithubbot merged 1 commit into from
Apr 16, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Apr 16, 2022

This is part of the migration of engine recipes to v2.

Bug: flutter/flutter#81855

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc godofredoc changed the title Add linux_host_engine v2 builder. Add mac_host_engine v2 builder. Apr 16, 2022
@godofredoc godofredoc mentioned this pull request Apr 16, 2022
Closed
@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 16, 2022
@fluttergithubbot fluttergithubbot merged commit da36d38 into flutter:main Apr 16, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 17, 2022
@engine-flutter-autoroll
da36d38 Add mac_host_engine v2 builder. (flutter/engine#32721)
1ad543f
@godofredoc godofredoc deleted the enable_linux_host_engine branch April 19, 2022 03:03
justinmc pushed a commit to justinmc/engine that referenced this pull request Apr 20, 2022
@godofredoc @justinmc
Add mac_host_engine v2 builder. (flutter#32721)
ab0b867
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@keyonghan keyonghan Awaiting requested review from keyonghan

2 more reviewers

@flutter-dashboard flutter-dashboard[bot] flutter-dashboard[bot] approved these changes

@yusuf-goog yusuf-goog yusuf-goog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @yusuf-goog @fluttergithubbot