Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[ci-fuchsia] Add "clobber" property to Linux Fuchsia #32717

Merged
akbiggs merged 1 commit into from
Apr 17, 2022
Merged

[ci-fuchsia] Add "clobber" property to Linux Fuchsia #32717

akbiggs merged 1 commit into from
Apr 17, 2022

Conversation

@richkadel
Copy link

@richkadel richkadel commented Apr 15, 2022 •
edited
Loading

Fixes: flutter/flutter#102013

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

keyonghan
keyonghan approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding this.

@richkadel
Copy link
Author

richkadel commented Apr 15, 2022

@keyonghan - The Linux Fuchsia FEMU builder just failed with the same error:

FAILED: dartlang/gen/flutter/tools/fuchsia/dart/fidl_source_verification.missing 
python3 ../../flutter/tools/fuchsia/dart/verify_sources.py --source_dir /b/s/w/ir/cache/builder/src/fuchsia/sdk/linux/dart/fidl/lib --stamp /b/s/w/ir/cache/builder/src/out/fuchsia_debug_x64/dartlang/gen/flutter/tools/fuchsia/dart/fidl_source_verification.missing fidl.dart src/bits.dart src/codec.dart src/codegen_common.dart src/enum.dart src/error.dart src/hash_codes.dart src/interface.dart src/interface_async.dart src/message.dart src/struct.dart src/table.dart src/types.dart src/union.dart src/unknown_data.dart src/wire_format.dart

Source files found that were missing from the "sources" parameter:
/b/s/w/ir/cache/builder/src/fuchsia/sdk/linux/dart/fidl/lib/src/optional_nullable.dart

I think I need to add the clobber property to that builder as well.

@richkadel richkadel force-pushed the fix-ci-fuchsiasdk-caching branch from abf90fb to b7c759e Compare April 15, 2022 22:59
@richkadel
Copy link
Author

richkadel commented Apr 16, 2022

@arbreng @chaselatta @akbiggs

This fixes the broken Fuchsia CI builders. We just need someone with write permissions to merge it. Thanks!

@akbiggs akbiggs added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 17, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 17, 2022

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 17, 2022
@akbiggs akbiggs added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 17, 2022
@akbiggs akbiggs merged commit 3c6d4da into flutter:main Apr 17, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 17, 2022
@engine-flutter-autoroll
3c6d4da [ci-fuchsia] Add "clobber" property to Linux Fuchsia (flutter…
3f27d92 
…/engine#32717)
justinmc pushed a commit to justinmc/engine that referenced this pull request Apr 20, 2022
@justinmc
[ci-fuchsia] Add "clobber" property to Linux Fuchsia (flutter#32717)
f535ccb 
Fixes: 102013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@akbiggs akbiggs akbiggs approved these changes

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linux Fuchsia CI test is failing on a Fuchsia SDK file that doesn't actually exist in the SDK yet

4 participants

@richkadel @fluttergithubbot @akbiggs @keyonghan