-
Notifications
You must be signed in to change notification settings - Fork 6k
Fix nullability annotation in writeValue #32706
Fix nullability annotation in writeValue #32706
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
blasten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
test-exempt: code refactor with no semantic change |
|
Can we cp this? @blasten |
|
This does not yet appear to be in the latest release of flutter; is there any update on when it will be released? |
|
We have stable releases every ~3 months, and betas every ~month, so it's probably in the current beta and will probably be in the next stable. |
Fixes flutter/flutter#101991
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.