Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@nt4f04uNd
Copy link
Member

Fixes flutter/flutter#101991

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@nt4f04uNd nt4f04uNd requested a review from blasten April 15, 2022 16:55
@nt4f04uNd nt4f04uNd changed the title Fix nullablity annotation in writeValue Fix nullability annotation in writeValue Apr 15, 2022
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 15, 2022
@fluttergithubbot fluttergithubbot merged commit b700173 into flutter:main Apr 15, 2022
@Hixie
Copy link
Contributor

Hixie commented Apr 15, 2022

test-exempt: code refactor with no semantic change

@nt4f04uNd nt4f04uNd deleted the fix-android-annotation branch April 15, 2022 19:09
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 15, 2022
justinmc pushed a commit to justinmc/engine that referenced this pull request Apr 20, 2022
@lntls
Copy link

lntls commented May 13, 2022

Can we cp this? @blasten
The flutter 3.0 get
捕获

@matthewjsummers
Copy link

This does not yet appear to be in the latest release of flutter; is there any update on when it will be released?

@Hixie
Copy link
Contributor

Hixie commented Jul 23, 2022

We have stable releases every ~3 months, and betas every ~month, so it's probably in the current beta and will probably be in the next stable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong nullabilty annotation in the Android embedding

6 participants