[web] Migrate Flutter Web DOM usage to JS static interop - 1 #32689
Conversation
flutter-dashboard
bot
added
the
platform-web
joshualitt
force-pushed
the
html_1
branch
5 times, most recently
from
b7700a4 to
ee86be3
Compare
|
@srujzs @rileyporter ptal. Unfortunately, due to how the engine is built, I can't use an import prefix, so I had to name space Please pay particular attention to nullability. |
rileyporter
left a comment
rileyporter
left a comment
There was a problem hiding this comment.
LGTM, it's interesting to see what you've needed in dom.dart. I'll be curious to see what else you end up needing.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@yjbanov @eyebrowsoffire ptal. I think it would be a good idea for both of you to look at this first cl. The rest of the CLs look a lot like this one. |
|
test-exempt: code refactor with no semantic change |
|
@yjbanov , I'm going to land this just to see if there are any hiccups with this approach. If you have any feedback on this CL, please let me know and I will be happy to address it in one of the numerous follow ons. |
5 participants
This is CL 1 in a series of CLs to migrate Flutter Web DOM usage to the new JS static interop API.
Note: Because we have not quite finished the new DOM library based on JS static interop, this CL introduces a shim library which should mostly match the forthcoming API. A subsequent much smaller migration will occur once the new library is complete.