Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Linux, Keyboard] Derive keyboard layout using printable information from system #32665

Merged
dkwingsmt merged 14 commits into from
Apr 21, 2022
Merged

[Linux, Keyboard] Derive keyboard layout using printable information from system #32665

dkwingsmt merged 14 commits into from
Apr 21, 2022

Conversation

@dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Apr 14, 2022 •
edited
Loading

This PR changes how Flutter derives logical keys on Linux. By gathering the keyboard layout information and analyzing them as a whole, Flutter can build the key map and fix problems that can not be overcome by calculating on a per-key basis.

This PR is parallel to #32152, using the same algorithm, and should result in a similar (if not identical) layout.

This addresses the first phase of flutter/flutter#100456 on Linux, but requires an additional PR to apply to RawKeyboard and Shortcut.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dkwingsmt dkwingsmt requested a review from gspencergoog April 14, 2022 00:57
gspencergoog
gspencergoog approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@dkwingsmt dkwingsmt added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. affects: text input and removed platform-macos labels Apr 20, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Apr 21, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Framework Smoke Tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 21, 2022
@dkwingsmt dkwingsmt merged commit 4228b72 into flutter:main Apr 21, 2022
@dkwingsmt dkwingsmt deleted the linux-keyboard-layout-detection branch April 21, 2022 07:48
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
4228b72 [Linux, Keyboard] Derive keyboard layout using printable info…
0149217 
…rmation from system (flutter/engine#32665)
@dkwingsmt dkwingsmt mentioned this pull request Apr 28, 2022
Merged
8 tasks
@jpnurmi jpnurmi mentioned this pull request Jun 28, 2022
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gspencergoog gspencergoog gspencergoog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

affects: text input embedder Related to the embedder API platform-linux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dkwingsmt @fluttergithubbot @gspencergoog