This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: Ignore armv7 in ios framework script #32664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Putting this back up just in case it becomes safe to land while I'm OOO. |
Member
|
Thanks Zach. Blocked on flutter/flutter#101793 do not merge until that is fixed. |
Member
|
flutter/flutter#101793 merged so this should be ready to try. I'll test locally tomorrow and LGTM then. I expect this may cause some unexpected issues in the framework, so I'll escort this through the roll. |
jmagman
added
waiting for tree to go green
This was referenced Apr 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2022
justinmc
pushed a commit
to justinmc/engine
that referenced
this pull request
Apr 20, 2022
9 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
We dropped support for armv7 iOS devices in: * Framework: flutter/flutter#97342. * Buildroot: flutter/buildroot#569 * Engine: #32664 * Recipes: * https://flutter-review.googlesource.com/c/recipes/+/29060 * https://flutter-review.googlesource.com/c/recipes/+/29060 (revert) * https://flutter-review.googlesource.com/c/recipes/+/29582 (reland) * Issue: flutter/flutter#97345 This eliminates the code (and an unused flag) to deal with producing zip archives including components for the armv7 architecture. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #32638
Related flutter/flutter#97327