This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux] add (Fl)MockBinaryMessenger for GMock #32649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the common naming convention for fake implementations, and makes room for a GMock-based mock implementation that registers calls and allows settings expectations.
GMock doesn't support mocking plain C-functions but GTypeInterface calls can be forwarded to a mock object in a way that looks a lot like mocking plain C-functions: ```c testing::flutter::MockBinaryMessenger mock; FlBinaryMessenger* messenger = fl_binary_messenger_new_mock(mock); EXPECT_CALL(mock, fl_binary_messenger_send_on_channel(...)).WillOnce(...); do_something(messenger); ```
8 tasks
chinmaygarde
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
chinmaygarde
approved these changes
Apr 14, 2022
chinmaygarde
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2022
justinmc
pushed a commit
to justinmc/engine
that referenced
this pull request
Apr 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation step split off from #32618 that will eventually fix light
vs. dark theme detection on Linux (flutter/flutter#101438).
GMock doesn't support mocking plain C-functions but GTypeInterface calls
can be forwarded to a mock object in a way that looks a lot like mocking
plain C-functions:
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.