This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Designated field initialization of Paint/PrerollContexts #32634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flar
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 13, 2022
justinmc
pushed a commit
to justinmc/engine
that referenced
this pull request
Apr 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've apparently had access to this C++ feature for a while, but have been using ad-hoc comments to document/manage our initializations of the PaintContext and PrerollContext. Using the designated field initializers (
{ .field = val, ...}), the initializers are self-documenting and could even be pared down to the bare minimum of fields that are required.I did not pare down any existing initializers, but the added unit tests demonstrate just how minimal the initializer lists can be.