Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[WIP] Raster cache TransformLayers if it is marked as 'use_raster_cache' #32615

Closed
ColdPaleLight wants to merge 3 commits into from
Closed

[WIP] Raster cache TransformLayers if it is marked as 'use_raster_cache' #32615

ColdPaleLight wants to merge 3 commits into from

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Apr 12, 2022 •
edited
Loading

TransformLayer adds the flag use_raster_cache, if it is set, then TransformLayer will participate in raster caching. This feature is used for RepaintBoundary to cache layer content, aiming to improve scrolling performance of complex lists.

framework PR: flutter/flutter#101754

fix flutter/flutter#91648

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

This was referenced Apr 12, 2022
Closed
Closed
@ColdPaleLight ColdPaleLight changed the title Raster cache TransformLayers if it is marked as 'use_raster_cache' [WIP]Raster cache TransformLayers if it is marked as 'use_raster_cache' Apr 12, 2022
@ColdPaleLight ColdPaleLight marked this pull request as draft April 14, 2022 04:30
@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 14, 2022

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@ColdPaleLight ColdPaleLight mentioned this pull request Apr 15, 2022
Closed
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Apr 19, 2022
@ColdPaleLight ColdPaleLight changed the title [WIP]Raster cache TransformLayers if it is marked as 'use_raster_cache' Raster cache TransformLayers if it is marked as 'use_raster_cache' Apr 19, 2022
@ColdPaleLight ColdPaleLight marked this pull request as ready for review April 19, 2022 08:39
@ColdPaleLight ColdPaleLight changed the title Raster cache TransformLayers if it is marked as 'use_raster_cache' [WIP] Raster cache TransformLayers if it is marked as 'use_raster_cache' Apr 19, 2022
@ColdPaleLight ColdPaleLight added the Work in progress (WIP) Not ready (yet) for review! label May 1, 2022
@ColdPaleLight
Copy link
Member Author

ColdPaleLight commented May 16, 2022

Closing it, more context please see flutter/flutter#91648 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

platform-web Code specifically for the web engine Work in progress (WIP) Not ready (yet) for review!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TransformLayer should participate in raster caching

1 participant

@ColdPaleLight