Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Win32: The vertical offset of the IME is incorrect when compared with native Windows apps #32567

Merged
cbracken merged 1 commit into from
Apr 14, 2022
Merged

Win32: The vertical offset of the IME is incorrect when compared with native Windows apps #32567

cbracken merged 1 commit into from
Apr 14, 2022

Conversation

@moko256
Copy link
Contributor

@moko256 moko256 commented Apr 9, 2022 •
edited
Loading

Setting CFS_CANDIDATEPOS in CANDIDATEFORM seems reserving spaces for text drawn by IME. The CFS_EXCLUDE remove it.
I couldn't write test for this.
fixed example

Fix: flutter/flutter#101642

No changes in flutter/tests.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Apr 9, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@moko256 moko256 changed the title On Windows, reduce spaces between caret and IME window. Win32: The vertical offset of the IME is incorrect when compared with native Windows apps Apr 11, 2022
@cbracken cbracken self-requested a review April 14, 2022 18:32
cbracken
cbracken approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This calls for the LGTM hanko. Thank you!

LGTM stamp from a Japanese personal seal

@cbracken cbracken merged commit 27ee1ef into flutter:main Apr 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2022
@engine-flutter-autoroll
27ee1ef On Windows, reduce spaces between caret and IME window. (flut…
f856f35 
…ter/engine#32567)
@cbracken
Copy link
Member

cbracken commented Apr 14, 2022

I have some thoughts on how we can test this, but requires me to add some test infrastructure first.

justinmc pushed a commit to justinmc/engine that referenced this pull request Apr 20, 2022
@moko256 @justinmc
On Windows, reduce spaces between caret and IME window. (flutter#32567)
4272689
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs tests platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Windows]The vertical offset of the IME is incorrect when compared with native Windows apps

2 participants

@moko256 @cbracken