This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Win32: fix window commits last char when deleting text with IME #32565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Apr 15, 2022
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
This lgtm. Thank you for the fix.
I'll manually test with Korean IME as well, since historically, we've seen a bunch of very frustrating competing behaviour where Chinese/Japanese expect one behaviour, but Korean has a slightly different behaviour (in particular compose/result messages ordered differently).
cbracken
added
the
waiting for tree to go green
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
fluttergithubbot
removed
the
waiting for tree to go green
Member
|
Adding @gspencergoog or @LongCatIsLooong for a second review. |
cbracken
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 15, 2022
justinmc
pushed a commit
to justinmc/engine
that referenced
this pull request
Apr 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar problem to flutter/flutter#92132 is occured by using Google Japanese Input, and Microsoft Japanese IME.
In this case, a WM_IME_COMPOSITION message with zero lparam is posted. (this behavior is documented in https://docs.microsoft.com/en-us/windows/win32/intl/wm-ime-composition)
This PR adds processing this.
Fixes: flutter/flutter#101953
No changes in
flutter/tests.Pre-launch Checklist
writing and running engine tests.
///).